Stop morph e2e runs from blocking on server stdout#706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Morph e2e runs now keep the live Emanote server responsive for the whole smoke file. The harness used to spawn
emanote runwith stdout piped, but never read it; after enough route/render output, that pipe could fill and block the child process. The observed failure was late injust e2e-morph, where freshpage.goto("/")calls timed out while priming morph navigation.The fix sends routine stdout to
/dev/nullwhile preserving stderr under the existing[emanote:live]prefix. That addresses the server backpressure root cause without filtering scenarios, raising timeouts, or weakening assertions.Verification
just e2e-live— 42 scenarios / 132 steps passedjust e2e-static— 39 passed, 3@morphscenarios skipped as expectedjust e2e-morph— 42 scenarios / 132 steps passedjust fmt— cabal-fmt, fourmolu, hlint, nixpkgs-fmt passedGenerated by Codex (model
gpt-5).